helm/ulysses
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Ignore non-object settings scrub inputs (#1645)

Browse source
This commit is contained in:
red person 2026-06-03 08:11:05 +03:00 • committed by GitHub
parent b409b20940
commit d1309f3bd6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/settings_scrub.py
View file

@ -47,4 +47,6 @@ def _scrub_value(key, value):
def scrub_settings(settings: dict) -> dict: def scrub_settings(settings: dict) -> dict:
"""Return a copy of ``settings`` with secret-shaped values masked (deep).""" """Return a copy of ``settings`` with secret-shaped values masked (deep)."""
if not isinstance(settings, dict):
return {}
return {k: _scrub_value(k, v) for k, v in (settings or {}).items()} return {k: _scrub_value(k, v) for k, v in (settings or {}).items()}

5
tests/test_settings_scrub.py
View file

@ -59,3 +59,8 @@ def test_empty_and_nonstring_secret_values_untouched():
def test_exact_name_matches(): def test_exact_name_matches():
out = scrub_settings({"password": "p", "token": "t", "secret": "s", "apikey": "a", "key": "k"}) out = scrub_settings({"password": "p", "token": "t", "secret": "s", "apikey": "a", "key": "k"})
assert all(v == "" for v in out.values()), out assert all(v == "" for v in out.values()), out
def test_non_object_settings_return_empty_mapping():
assert scrub_settings(["not", "settings"]) == {}
assert scrub_settings("not settings") == {}