helm/ulysses
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: remove 'Preview is read-only' click hint toast
Some checks are pending
ci / docker publish / build (amd64) (push) Waiting to run
Details
ci / docker publish / build (arm64) (push) Waiting to run
Details
ci / docker publish / merge manifest + tag (push) Blocked by required conditions
Details

Browse source 
_handleMarkdownPreviewClickHint() now no-ops. The toast appeared after
3 rapid clicks in the markdown preview and told the user to click Write to
edit — annoying for users who click-drag to highlight while reading. Users
self-hosting Odysseus know how preview/write modes work.
This commit is contained in:
Lukas Parsons 2026-07-07 13:31:40 -04:00
parent 88e15987d2
commit a9d0df0b50
1 changed files with 1 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
static/js/document.js
View file

@ -10008,24 +10008,7 @@ import { bindMenuDismiss, dismissOrRemove } from './escMenuStack.js';
} }
function _handleMarkdownPreviewClickHint() { function _handleMarkdownPreviewClickHint() {
if (!_isMarkdownPreviewVisible()) return; // Intentionally removed — click-to-highlight while reading is normal behavior
const lang = ((docs.get(activeDocId)?.language) || document.getElementById('doc-language-select')?.value || '').toLowerCase();
if (lang !== 'markdown') return;
const now = Date.now();
_mdPreviewClickTimes = _mdPreviewClickTimes.filter(ts => now - ts < 2500);
_mdPreviewClickTimes.push(now);
if (_mdPreviewClickTimes.length < 3 || now - _mdPreviewHintLastAt < 5000) return;
_mdPreviewHintLastAt = now;
_mdPreviewClickTimes = [];
if (uiModule?.showToast) {
uiModule.showToast('Preview is read-only. Click Write to edit the document.', {
duration: 5000,
action: 'Write',
onAction: () => _setMarkdownPreviewActive(false, { remember: true }),
});
}
} }
function _refreshMarkdownPreviewIfVisible(docId, content) { function _refreshMarkdownPreviewIfVisible(docId, content) {