helm/ulysses
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: zoom-aware dropdown positioning in session list + archive/research menus

Browse source 
getBoundingClientRect() returns zoom-scaled coords, but
window.innerWidth is unscaled. rect.right/z computed offset was
wildly negative at ui-scale-125, pushing dropdowns off-screen left.
Both createSessionItem() dropdown (rename/delete/archive) and
_showDropdown() (archive/research library cards) affected.
This commit is contained in:
Lukas Parsons 2026-07-07 15:12:59 -04:00
parent 33d133b2da
commit 5d674fe61b
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
static/js/sessions.js
View file

@ -825,17 +825,18 @@ function createSessionItem(s) {
} else { } else {
// Position the dropdown using viewport coords // Position the dropdown using viewport coords
const rect = menuBtn.getBoundingClientRect(); const rect = menuBtn.getBoundingClientRect();
const z = parseFloat(getComputedStyle(document.documentElement).zoom) || 1;
dropdown.style.left = ''; dropdown.style.left = '';
dropdown.style.right = (window.innerWidth - rect.right) + 'px'; dropdown.style.right = (window.innerWidth - rect.right / z) + 'px';
// Show off-screen first to measure height // Show off-screen first to measure height
dropdown.style.top = '-9999px'; dropdown.style.top = '-9999px';
dropdown.style.display = 'block'; dropdown.style.display = 'block';
const ddRect = dropdown.getBoundingClientRect(); const ddRect = dropdown.getBoundingClientRect();
// Flip above if not enough room below // Flip above if not enough room below
if (rect.bottom + 2 + ddRect.height > window.innerHeight) { if (rect.bottom / z + 2 + ddRect.height / z > window.innerHeight) {
dropdown.style.top = Math.max(2, rect.top - ddRect.height - 2) + 'px'; dropdown.style.top = Math.max(2, rect.top / z - ddRect.height / z - 2) + 'px';
} else { } else {
dropdown.style.top = rect.bottom + 2 + 'px'; dropdown.style.top = rect.bottom / z + 2 + 'px';
} }
} }
}); });
@ -2669,14 +2670,15 @@ function _showDropdown(anchorEl, items) {
// Position using viewport coords (same pattern as session menus) // Position using viewport coords (same pattern as session menus)
const rect = anchorEl.getBoundingClientRect(); const rect = anchorEl.getBoundingClientRect();
dd.style.right = (window.innerWidth - rect.right) + 'px'; const z = parseFloat(getComputedStyle(document.documentElement).zoom) || 1;
dd.style.right = (window.innerWidth - rect.right / z) + 'px';
dd.style.top = '-9999px'; dd.style.top = '-9999px';
dd.style.display = 'block'; dd.style.display = 'block';
const ddRect = dd.getBoundingClientRect(); const ddRect = dd.getBoundingClientRect();
if (rect.bottom + 2 + ddRect.height > window.innerHeight) { if (rect.bottom / z + 2 + ddRect.height / z > window.innerHeight) {
dd.style.top = Math.max(2, rect.top - ddRect.height - 2) + 'px'; dd.style.top = Math.max(2, rect.top / z - ddRect.height / z - 2) + 'px';
} else { } else {
dd.style.top = (rect.bottom + 2) + 'px'; dd.style.top = (rect.bottom / z + 2) + 'px';
} }
function close() { dd.remove(); } function close() { dd.remove(); }